Closed MahShaaban closed 7 years ago
Great job Man and thank you for your contribution. Being able to plot a collection of samples will be extremely useful to the community.
Please make sure to add your name in the documentation to give you the credit.
#'@author Mahmoud Shaaban, \email{mahmoud.s.fahmy@@students.kasralainy.edu.eg}
I am glad you find the suggestions interesting, @kassambara. I will follow with another pull request with the plotting functions for the other modules.
Hi @kassambara, I have been working on a package similar to fastqcr, then I found about yours and I think it's well written. I would like to suggest some code to enable a visual comparison between multiple samples:
qc_read_collection
: a simple wrapper to use your functionqc_read
to read multiple FastQC files in a way consistent with other package functions. The output of this function is an object of classqc_read_collection
that can be used to make overlaying plots.This is supposed to work along the lines of the original function, so the output is a list of tibbles and each tibble has an extra column
sample
to track the original file.Output of `r head(qc)`
.plot_gc_content
that produces a line graph of the GC content of multiple samples.And here is the output of calling
plot_gc_content_collection(qc)
If you find these suggestions interesting, I can write the extensions to plotting other modules and figure out a dispatch method on the original
qc_read
class andqc_read_collection
.