neoterm size doesn't work

[musaffa]

I'm using neoterm with vim-test. I've tried to set vertical size with neoterm_size but it doesn't seem to work. It always takes the half of the current window.

let test#strategy = 'neoterm'
let g:neoterm_size = 30

I also tried with quoted number: let g:neoterm_size = "30". No result.

[kassio]

I wasn't able to replicate the behaviour. Can you give me more information, or a gif? Thanks

[kassio]

btw, I tried with:

  let g:neoterm_position = "vertical"
  let g:neoterm_size = 30

[musaffa]

Size works with vertical positioning. But it doesn't seem to work with horizontal positioning. Regardless of the size I set, this is what I see in the editor:

[kassio]

Can you put here your neoterm configurations?

[musaffa]

It is just:

let test#strategy = 'neoterm'
let g:neoterm_size = 30

[kassio]

Hum.. but this seems to be right, if you put the focus on the neoterm window you can do :echo winheight('%') and this will return 30. Now if you want you neoterm to be vertical you'll need to set let g:neoterm_position = "vertical".

[musaffa]

But I prefer horizontal positioning. :(

[kassio]

So, it's already working?! right?! have you checked the window size with :echo winheight('%')?

[musaffa]

Oh didn't realize 30 is the half of the whole window. I was thinking in terms of vimux where 30 produced much smaller height.

Thanks for your time. :)

[ghost]

Same issue here, g:neoterm_size seems doesn't work with horizontal positioning.

[codeinabox]

How does this option now work in relation to g:neoterm_default_mod? I have the following settings but I noticed the size option no longer has any effect

let g:neoterm_size = 10
let g:neoterm_default_mod = 'split'

[kassio]

@codeinabox with the new api something probably broke. Can you open a new issue, please?

[codeinabox]

Done, new issue is #202