kastnermario / yaml-cpp

Automatically exported from code.google.com/p/yaml-cpp
MIT License
0 stars 0 forks source link

.pc file specifies wrong include dir #122

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
It specifies root dir not the dir with the includes themselves.

Fix:
sed -i -e 's:INCLUDE_INSTALL_ROOT_DIR:INCLUDE_INSTALL_DIR:g' yaml-cpp.pc.cmake

Original issue reported on code.google.com by tomas.ch...@gmail.com on 16 Sep 2011 at 10:56

GoogleCodeExporter commented 8 years ago
On the other hand might be that you want us to use #include <yaml-cpp/yaml.h> 
instead of just #include <yaml.h> where I would have to update my sources :)

Original comment by tomas.ch...@gmail.com on 16 Sep 2011 at 11:08

GoogleCodeExporter commented 8 years ago
That's correct :)

Original comment by jbe...@gmail.com on 16 Sep 2011 at 5:22

GoogleCodeExporter commented 8 years ago
Shouldn't the include path choice be down to the specific platform or program 
configuration though? Stuff like OSX Frameworks are self-contained libraries 
which don't have a "yaml-cpp" subfolder, and including it like that won't work. 

And Unix programs like pkg-config will always return the paths to the specific 
library include and not the overall include, or we wouldn't even need such 
programs in the first place.

Original comment by supsu...@gmail.com on 16 Sep 2011 at 7:20

GoogleCodeExporter commented 8 years ago
I dunno. I mean, I'd rather people include it as "yaml-cpp/yaml.h". If you add 
the "include/yaml-cpp" folder to your include path, then you might have some 
other included files that get confused with common yaml headers as well.

And OS X frameworks do have subfolders. For example, you always do

#import <Foundaton/Foundation.h>

I guess you're right about things like pkg-config returning paths to the 
specific library include, but I'm not sure why. I mean, you could really get 
hurt by doing that.

Original comment by jbe...@gmail.com on 16 Sep 2011 at 7:29