search

kasugaijin / baja-pet-rescue

Kasugaijin's open-source Ruby on Rails production app that enables dog rescue organisation staff in Mexico to post dogs and receive applications for adoption from users in USA and Canada..
27 stars 9 forks source link

Possible dead code in app/services? #165

Closed egemen-dev closed 1 year ago

egemen-dev commented 1 year ago

While working on service object https://github.com/kasugaijin/baja-pet-rescue/pull/160 I noticed that there might be a possible dead code in app/services/geocode_backfilled_location.rb the class GeocodeBackfilledLocation itself is not used anywhere, I wonder are you keeping this code for future use or it's forgotten?

kasugaijin commented 1 year ago

Yes this should really live in a rake task as it is a database related task that I executed when I refactored the locations data to create data for google maps. I decoupled location data from adopter profile data, and ran that task to generate coordinates. This ticket could be to move that logic to a rake task instead that can be called from the console at a later date. However, I am not sure I will need to call it again...so it could also be removed. Let me know if you're interested.

egemen-dev commented 1 year ago

Yes. You can assign it to me and I will open a PR to remove it. @kasugaijin

kasugaijin commented 1 year ago

Assigned @egemen-dev