Contact form tests - Githubissues

kasugaijin / baja-pet-rescue

Kasugaijin's open-source Ruby on Rails production app that enables dog rescue organisation staff in Mexico to post dogs and receive applications for adoption from users in USA and Canada..

27 stars 9 forks source link

Contact form tests #57

Closed Eduardo06sp closed 1 year ago

Eduardo06sp commented 1 year ago

Summary of changes:

Added validation messages to the contact form, they were missing (views/contacts/new.html.erb)
Added a couple of integration tests to test the presence of validation messages, then a test for successful submission

Closes issue: #44

kasugaijin commented 1 year ago

Looks great! Thank you for adding the error messages in the views. Definitely an oversight of mine and I must have been just manually testing with 'required' in HTML and forgot to add the markup for displaying backend validations. I also learned about assert_emails, too.