search

kasunkv / slack-notification

Slack Notification task with advanced slack message customization for Visual Studio Team Services
MIT License
20 stars 9 forks source link

Change default channel from #general to #mychannelname #1

Closed stewx closed 6 years ago

stewx commented 6 years ago

Having the default channel set to #general in this task is risky because if users are not paying close attention they can set up tasks that spam a company-wide channel with a lot of unwanted messages. Having this set by default to #mychannelname will make it more obvious that this value should be changed from the default.

kasunkv commented 6 years ago

@stewx Thanks for the contribution. I understand your point and its true. My suggestion is that we should not add a default channel name. Let's remove the default channel name value and since its a required configuration, it will be highlighted and it will grab the users attention. That is a better approach in my opinion. What do you think? if you agree, please update the PR by removing the default channel name. And i'll be happy to merge this in and release a new version. Once again. Thank you for the feedback and contribution.. :)

stewx commented 6 years ago

@kasunkv Done

kasunkv commented 6 years ago

@stewx Thank You.. :)