search

kat-kan / kawqa-gad-playwright

4 stars 1 forks source link

Fix/issue 97 fix future date test from articles post file #102

Closed kat-kan closed 2 months ago

kat-kan commented 6 months ago

Resolves #97

Scope of changes:

Started as fix, evolved into testing more date formats. This is a draft as I want Your opinion if You like this idea.

How to use it:

N/A

Any other comments?

...

Before submitting Pull Request, I've ensured that:

Justyna-KO commented 5 months ago

@kat-kan I think it's a good idea to perform our tets for different dates. I like that we don't duplicate the code for these tests thanks to the loop. One test fails with me: Returns 201 Created after creating article with date 2023-06-24T13:05:45.155Z Expected: 201 Received: 422 There is a problem with the appropriate assertions for different dates.

Slawomir-DKl commented 5 months ago

@kat-kan I think it's a good idea to perform our tets for different dates. I like that we don't duplicate the code for these tests thanks to the loop. One test fails with me: Returns 201 Created after creating article with date 2023-06-24T13:05:45.155Z Expected: 201 Received: 422 There is a problem with the appropriate assertions for different dates.

@Justyna-KO @kat-kan I've found the reason. Please take look at the comment to the line 16

kat-kan commented 4 months ago

@Justyna-KO @Slawomir-DKl and any others who'd like to contribute in code review: as the idea to run tests against different data formats is approved, I removed draft type from PR. I believe it is ready to merge. I added Your suggestions. The tests parameterization is yet to be introduced in comments tests - I will create another issue for this task. I will also create issue for unique article titles (new validation in GAD that was mentioned by @Slawomir-DKl)