search

kat-kan / kawqa-gad-playwright

4 stars 1 forks source link

[ISSUE#67]POST comments/ - add test #68

Closed Justyna-KO closed 9 months ago

Justyna-KO commented 11 months ago

Resolves #67

Add tests: 201 created, 400 bad request, 422 Invalid comment supplied

kat-kan commented 11 months ago

@Justyna-KO congrats on your first PR 🥳 You will be able to merge after receiving 2 approvals during code review.

PS please make use of our PR/issue templates (the autogenerated description with gaps to be filled visible when you create issue/PR). We use it as a standard and to help each other understand the scope of task.

Justyna-KO commented 10 months ago

Thank you for your patience :) overall, awesome job! My two cents on PR:

  1. Please use Prettier and you won't have to worry about formatting problems like redundant empty lines.
  2. The branch name does not match the agreed pattern. Didn't you encounter problems while committing? The branch name is validated and the example of valid name is "tests/ISSUE-16_Post_Login_endpoint_tests"

I removed redundant empty lines. I noticed that Prettier does not always remove them.

I did not encounter any problems while committing. During future commits I will follow this rule. Renaming the current branch would be problematic.

bugITwhisperer commented 10 months ago

@Justyna-KO : congrats on your 1st PR - great work! 💪🏻 😸

Justyna-KO commented 9 months ago

It's good to be merged now :)

I had to make another commit because of the conflict. It needs new approve:-)