kat0h / bufpreview.vim

A markdown previewer for Vim and Neovim
MIT License
96 stars 11 forks source link

#28 Update frontend to bundle for CORS. #32

Closed daizu39 closed 1 year ago

daizu39 commented 1 year ago

It uses the following techniques:

kat0h commented 1 year ago

Thanks for the great PullRequest! It seems to be working fine on my pc!

I am not familiar with esbuild so I have a few questions.

I am so glad you fixed bufpreview.vim that was broken for so long! Thank you.

daizu39 commented 1 year ago

"denops/bufpreview/lib/filetype/markdown/client/markdown.bundle.js" looks like a very large file. I think it can be removed as it can be generated whenever you want by running $ deno task prepare.

It's my mistake. I delete "denops/bufpreview/lib/filetype/markdown/client/markdown.bundle.js".

In the original version, the browser window was automatically closed when the connection to deno was broken. However, the new implementation does not seem to work.

I fix this behavior.

kat0h commented 1 year ago

LGTM!!!!!! Thank you🎉