search

kat0r / oni_mods

MIT License
3 stars 4 forks source link

support also Freezer and Dupes Refrigeration mods #4

Closed llunak closed 1 year ago

llunak commented 1 year ago

I've just done this for my mod, so you can reuse this.

Note that I haven't actually compiled this, as I don't know how to compile your project here on Linux. But it's copy&paste of my mode and a bit adjusted, so it should work, so at least be usable as a base.

Thundercraft commented 1 year ago

"Note that I haven't actually compiled this, as I don't know how to compile your project here on Linux."

I don't have experience modding ONI. But I tried following the GitHub guide to modding ONI as mentioned on the Discord and the Wiki. I really wanted to see if I could do this, so I spent hours downloading and setting up Visual Studio Community 2019 per instructions, trying to proceed from there... After several hiccups, I learned I had to edit 'ImprovedFilteredStorage.csproj' in Notepad+ because my PC username is different, my Steam and game install location is different, etc.

Long story short: I finally got kat0r's original code for ImprovedFilteredStorage to compile successfully. However, I could not get this proposed Pull Request code to compile in place of the original "Patches.cs". I made sure I copied it exactly as posted. (Well, originally, I had your old Pull Request... which failed. Then I came back here to see you updated it. So I tried the updated code, which also failed.)

I get 3 errors when I try to Build:

Error   CS0246  The type or namespace name 'MethodInfo' could not be found (are you missing a using directive or an assembly reference?)    ImprovedFilteredStorage C:\src\PartitionedStorage\ImprovedFilteredStorage\Patches.cs    165 Active

Error   CS0246  The type or namespace name 'OtherMods_Patch' could not be found (are you missing a using directive or an assembly reference?)   ImprovedFilteredStorage C:\src\PartitionedStorage\ImprovedFilteredStorage\Patches.cs    167 Active

Error   CS0246  The type or namespace name 'RefrigeratorThresholds' could not be found (are you missing a using directive or an assembly reference?)    ImprovedFilteredStorage C:\src\PartitionedStorage\ImprovedFilteredStorage\Patches.cs    173 Active

"...at least be usable as a base."

Maybe so. But do you have an idea of what's wrong? Could I just be missing a library/reference?

llunak commented 1 year ago

Fixed above-mentioned problems.

Thundercraft commented 1 year ago

Sorry for taking so long to test and report back. I got frustrated after my ONI installation became corrupted and I had to ultimately uninstall and reinstall to fix it.

Anyway, from my testing so far with minimal mods - just this PR code of yours I compiled into a modified version, plus "Mod Manager", "Stock Bug Fix" and "Dupes Refrigeration" - everything seems okay. I was able to add partitions to the Hightech Fridge and Blue Fridge and these seemed to function as intended. Though, I did not test the other fridges.