mount: Fix hugepages support

kata-containers / agent

Kata Containers version 1.x agent (for version 2.x see https://github.com/kata-containers/kata-containers). Virtual Machine agent for hardware virtualized containers

https://katacontainers.io/

Apache License 2.0

242 stars 113 forks source link

mount: Fix hugepages support #872

Closed bpradipt closed 3 years ago

bpradipt commented 3 years ago

Fixes: #871

Signed-off-by: Pradipta Banerjee pradipta.banerjee@gmail.com

bpradipt commented 3 years ago

/test-ubuntu

bpradipt commented 3 years ago

/test-vfio

bpradipt commented 3 years ago

/test-ubuntu

bpradipt commented 3 years ago

/test-vfio

bpradipt commented 3 years ago

/test-vfio

bpradipt commented 3 years ago

The vfio test failure is unrelated and looks like this is the cause /usr/bin/cloud-hypervisor does not exist .

@dgibson @jodh-intel can you please take a look at this PR. I have incorporated all the changes. Post your review I can start working on forward porting the hugepages changes to 2.x. Thanks

egernst commented 3 years ago

I have some questions still, from https://github.com/kata-containers/runtime/issues/2353#issuecomment-757059874

I’m okay with adding support, but I think it should be behind a feature gate, since I think this may cause issues in Kube (our memory overhead will consume a lot of the pages).

bpradipt commented 3 years ago

I have some questions still, from kata-containers/runtime#2353 (comment)

I’m okay with adding support, but I think it should be behind a feature gate, since I think this may cause issues in Kube (our memory overhead will consume a lot of the pages).

Sorry @egernst, I completely missed it. I have posted few questions and let's discuss to arrive at a consensus.

fidencio commented 3 years ago

/test-vfio

bpradipt commented 3 years ago

/test-vfio

devimc commented 3 years ago

hold on please, the CI didn't run

devimc commented 3 years ago

I'm investigating the issue

INFO: No forcing label found
Short circuit fast path skipping the rest of the CI.

devimc commented 3 years ago

@bpradipt - I see you want to merge this in master

bpradipt wants to merge 1 commit into kata-containers:master

is that correct?

bpradipt commented 3 years ago

@bpradipt - I see you want to merge this in master
bpradipt wants to merge 1 commit into kata-containers:master
is that correct?

This is for kata-containers/agent master (1.x)

devimc commented 3 years ago

CI is buggy, no changes were detected :disappointed:

+ info 'Checking for any changed files that will prevent CI fastpath return'
+ echo -e 'INFO: Checking for any changed files that will prevent CI fastpath return'
INFO: Checking for any changed files that will prevent CI fastpath return
++ can_we_skip
++ '[' '' = true ']'
+++ get_pr_changed_file_details_full
+++ local filters=
+++ filters+=A
+++ filters+=C
+++ filters+=M
+++ filters+=R
+++ filters+=UX
+++ git diff-tree -r --name-status --diff-filter=ACMRUX origin/master HEAD
++ filenames=
+++ echo ''
+++ awk '{print $NF}'
++ filenames=
++ '[' -z '' ']'
++ local_info 'No files found'
++ msg='No files found'
++ info 'No files found'
++ echo -e 'INFO: No files found'
INFO: No files found

devimc commented 3 years ago

/test-ubuntu /test-vfio

fidencio commented 3 years ago

/test-ubuntu

fidencio commented 3 years ago

On a side note, I decided to take a look at the jenkins-ci-ubuntu-18-04 and it's building the rust agent. Why? Oo