kata-containers / community

Apache License 2.0
213 stars 71 forks source link

Runtime: pass correct parameters for tap0_kata macvtap with acrn-dm to launch acrn vm #398

Closed hongzhanchen closed 6 months ago

hongzhanchen commented 6 months ago

According to https://projectacrn.github.io/3.0/developer-guides/hld/virtio-net.html, we may need to pass tap=tap0_kata for macvtap but currently it just pass like virtio-net ,tap0-kata,mac=**** which is not recognized by acrn.

patch:

diff --git a/src/runtime/virtcontainers/acrn_arch_base.go b/src/runtime/virtcontainers/acrn_arch_base.go index fa8ce0fe6..278c76045 100644 --- a/src/runtime/virtcontainers/acrn_arch_base.go +++ b/src/runtime/virtcontainers/acrn_arch_base.go @@ -426,7 +426,7 @@ func (netdev NetDevice) AcrnNetdevParam() []string { deviceParams = append(deviceParams, netdev.IFName) deviceParams = append(deviceParams, fmt.Sprintf(",mac=%s", netdev.MACAddress)) case MACVTAP:

hongzhanchen commented 6 months ago

Sorry , submit wrong place for the issue. I already filed new one on kata-containers repo