search

kata-containers / kata-containers

Kata Containers is an open source project and community working to build a standard implementation of lightweight Virtual Machines (VMs) that feel and perform like containers, but provide the workload isolation and security advantages of VMs. https://katacontainers.io/
Apache License 2.0
5.08k stars 1k forks source link

kata-deploy: improving the runtimeclasses checker and documentation #9822

Open wainersm opened 2 weeks ago

wainersm commented 2 weeks ago

While working on PR #9807 it was a little of a pain to pass the static checker for the runtimeClasses that kata-deploy deploys on the cluster. I realized that it wasn't the first time I had the same difficult to pass CI, likely because I wasn't able to run the checker locally. So here I am sending some improvements to allow devs to run the checker locally before submitting a PR. In particular, the LC_ALL=C trick was hurting my tentative to get the checker passing.

Taking that opportunity to also document how to add a new runtimeClass to kata-deploy.

wainersm commented 2 weeks ago

Tentatively making spell and commit checkers happy.

wainersm commented 1 week ago

Updated to address @beraldoleal 's suggestion; now the job's name is on first line.

wainersm commented 20 hours ago

Updated this PR to address @ldoktor 's comments.

wainersm commented 1 hour ago

Updated this: