search

kata-containers / kata-containers

Kata Containers is an open source project and community working to build a standard implementation of lightweight Virtual Machines (VMs) that feel and perform like containers, but provide the workload isolation and security advantages of VMs. https://katacontainers.io/
Apache License 2.0
5.08k stars 1k forks source link

osbuilder: allow rootfs builds w/o git or version file deps #9825

Open ms-mahuber opened 2 weeks ago

ms-mahuber commented 2 weeks ago

This allows to call tooling like the rootfs builder outside of a git environment. Calculating the VERSION_COMMIT field without warnings/errors depends on the presence of a VERSION file and on a git environment. We set the VERSION_COMMIT field to 'unknown' if the version cannot be properly calculated. This not only prevents errors in the Makefile but also prevents from rootfs.sh being called with an empty -o parameter, thus the distro parameter from being parsed incorrectly. The change also makes a rust version check optional for cases where we want to build the rootfs w/o building the agent and thus w/o the rust dependency

Fixes: 9824

ms-mahuber commented 1 week ago

A few comments, @ms-mahuber.

I've left a few new comments and split the change into two. I hope for the scope/intention of this PR/issue my changes make sense.