search

kata-containers / kata-containers

Kata Containers is an open source project and community working to build a standard implementation of lightweight Virtual Machines (VMs) that feel and perform like containers, but provide the workload isolation and security advantages of VMs. https://katacontainers.io/
Apache License 2.0
5.08k stars 1k forks source link

versions: Bump rust toolchain #9840

Closed stevenhorsman closed 1 week ago

stevenhorsman commented 1 week ago
stevenhorsman commented 1 week ago

@gkurz - FYI - I checked and the current kata-agent (pre image-rs bump) has an MSRV of 1.69.0

gkurz commented 1 week ago

@gkurz - FYI - I checked and the current kata-agent (pre image-rs bump) has an MSRV of 1.69.0

Thanks @stevenhorsman !

Strange because I get that with current main ab8a9882c18b8f058f4b91748492fde95b9836a3 when building with 1.69.0 :

error: package `home v0.5.9` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.69.0

I actually had to bump to 1.71.0 to be able to build :wink:

Just one request : can you push the lint and warning fixes before the version bump ? For the sake of bisectability.

stevenhorsman commented 1 week ago

@gkurz - FYI - I checked and the current kata-agent (pre image-rs bump) has an MSRV of 1.69.0

Thanks @stevenhorsman !

Strange because I get that with current main ab8a988 when building with 1.69.0 :

error: package `home v0.5.9` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.69.0

I actually had to bump to 1.71.0 to be able to build 😉

Interesting, I got:

   Check for toolchain '1.69.0-x86_64-unknown-linux-gnu' succeeded
   Finished The MSRV is: 1.69.0

Hopefully it doesn't matter anyway, but it's interesting that there is a difference

Just one request : can you push the lint and warning fixes before the version bump ? For the sake of bisectability.

Commit order flipped

stevenhorsman commented 1 week ago

Hi @gkurz - Are you happy with the commit order change?