search

kata-containers / kata-containers

Kata Containers is an open source project and community working to build a standard implementation of lightweight Virtual Machines (VMs) that feel and perform like containers, but provide the workload isolation and security advantages of VMs. https://katacontainers.io/
Apache License 2.0
5.08k stars 1k forks source link

runtime: fix missing of VhostUserDeviceReconnect parameter assignment #9849

Open markyangcc opened 1 week ago

markyangcc commented 1 week ago

Below commit implements the vhost-user-blk reconnection functionality, runtime: add reconnect timeout for vhost user block

However, this commit has missed assigning VhostUserDeviceReconnect when new the QEMU HypervisorConfig, resulting in VhostUserDeviceReconnect always set to default value 0.

Fixes: #9848

justxuewei commented 1 week ago

/test

markyangcc commented 1 week ago

/test

markyangcc commented 1 week ago

Thx @markyangcc for your contribution. Could you please add this message to git's commit ？You can follow the example IMO, this maybe only involve small changes but as a result of go format causing the whole HypervisorConfig change(L909 ->L979)

Yes, real change is add below line, most of changes caused by go format,

return vc.HypervisorConfig{
    // ...
    VhostUserDeviceReconnect: h.VhostUserDeviceReconnect,
}, nil

Also, commit message updated.