search

kata-containers / kata-containers

Kata Containers is an open source project and community working to build a standard implementation of lightweight Virtual Machines (VMs) that feel and perform like containers, but provide the workload isolation and security advantages of VMs. https://katacontainers.io/
Apache License 2.0
5.09k stars 1.01k forks source link

runtime: implement DAN in Go kata-runtime #9868

Open l8huang opened 1 week ago

l8huang commented 1 week ago

The DAN feature has already been implemented in kata-runtime-rs, and this commit brings the same capability to the Go kata-runtime.

Fixes: https://github.com/kata-containers/kata-containers/issues/9758

justxuewei commented 1 week ago

Hey @l8huang, thanks for bringing this to the runtime-go! It might take some time to review since it is a huge one. Btw, your commit messages (also GitHub's) are required to be revised to make the CI happy:

<INTRODUCTION ABOUT YOUR COMMIT>

Fixes: #<issue> (Not `Fix:`)

Signed-off-by: Xxx <Xxx@Xxx.com>
justxuewei commented 1 week ago

Hmm, the title SHOULD be changed to "runtime: implement..." instead of "runtime-go" :)

justxuewei commented 1 week ago

Would you mind splitting the runtime patch into two, one for introducing DAN, another one for adding VFIO? Please keep the commit to doing one thing only.

l8huang commented 1 week ago

Would you mind splitting the runtime patch into two, one for introducing DAN, another one for adding VFIO? Please keep the commit to doing one thing only.

One PR with two commits or two PRs?

justxuewei commented 1 week ago

One PR with two commits or two PRs?

IMHO, two PRs are better. One PR with two commits is ok to me as well.

l8huang commented 4 days ago

@justxuewei changes are split into different PRs, please take a look at https://github.com/kata-containers/kata-containers/pull/9895 and this one -- the VFIO part depends on this PR, I will push it later.

justxuewei commented 1 day ago

I think the new item should be added into config templates, which can be found at https://github.com/kata-containers/kata-containers/tree/main/src/runtime/config. You might refer to https://github.com/kata-containers/kata-containers/blob/main/src/runtime-rs/config/configuration-dragonball.toml.in#L376.