kata-containers / packaging

Kata Containers version 1.x packaging (for version 2.x see https://github.com/kata-containers/kata-containers).
https://katacontainers.io/
Apache License 2.0
119 stars 92 forks source link

Detect v2 schema and use correct long form of cri plugin #1050

Closed dsyer closed 4 years ago

dsyer commented 4 years ago

CRI has a v2 schema that seems to be the default in a lot of containerd installations. It uses a "long" form for the plugin id in the TOML config file.

Fixes #881. I couldn't find any tests for this script, and I don't really have time to learn how to build the whole project, but I did test this change with my config.toml and it worked.

grahamwhaley commented 4 years ago

Thanks @dsyer . The PR requires a few tweaks to meet our contribution guidelines, or the CI will kick it out. I'll list the ones I can see here. But, if you really don't have time to re-spin, then shout, and we can pick this up and re-PR it (and credit you).

grahamwhaley commented 4 years ago

/test thanks for the update @dsyer

grahamwhaley commented 4 years ago

/AzurePipelines run

grahamwhaley commented 4 years ago

/test-ubuntu

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
devimc commented 4 years ago

/test-snap