search

kata-containers / packaging

Kata Containers version 1.x packaging (for version 2.x see https://github.com/kata-containers/kata-containers).
https://katacontainers.io/
Apache License 2.0
119 stars 92 forks source link

qemu: add kata patches for QEMU 5 #1065

Closed devimc closed 4 years ago

devimc commented 4 years ago

qemu: add kata patches for QEMU 5

Add the following patches for QEMU 5:

fixes #1064

devimc commented 4 years ago

/test

devimc commented 4 years ago

/test

devimc commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
dagrh commented 4 years ago

My gut feel is that it would be better to be explicit about the read-only memory; i.e. you should pass a flag somewhere to say that you want to open it read-only. (Not looked at the 9p one)

devimc commented 4 years ago

@fidencio

About the first patch, I see you guys are carrying this for long enough, but why do we want to carry 9p stuff into a QEMU that does support virtiofs? Wouldn't be better to stick to virtiofs, instead?

9p is still the default FS, once we switch to virtiofs, we can remove this patch

Out of curiosity, I see why the first patch wouldn't be "upstreamable" ... but what about the second one? From the archive, I could see the patch was not denied. Wouldn't be worth to revisit that?

as @dagrh said, we need to pass a flag to explicitly open it as read-only, I have no cycles to work on that :cry: