experimental kernel in build-kernel.sh - is fine or clean this in feature?

ionutnechita commented 4 years ago

Hi Kata Team,

I try to download one kernel with this link: https://gitlab.com/virtio-fs/linux/-/archive/${version}/${kernel_tarball}

Exist one version available or this this code is old?

//get_kernel() {

if [[ ${experimental_kernel} == "true" ]]; then kernel_tarball="linux-${version}.tar.gz" curl --fail -OL "https://gitlab.com/virtio-fs/linux/-/archive/${version}/${kernel_tarball}" tar xf "${kernel_tarball}" mv "linux-${version}" "${kernel_path}" else

devimc commented 4 years ago

once virtiofs patches land in upstream, experimental kernel code will be removed

skaegi commented 4 years ago

virtiofs is in upstream 5.6+. It doesn't have the dax support but it still might be reasonable to move the experimental conf into common. This is what we're doing internally for our kernel builds.

egernst commented 4 years ago

I agree for the configuration option, but we'll still want to make sure we at least have CI in place for the upstream virtio-fs changes.

ariel-adam commented 4 years ago

Once we have all the virtiofs patches in place we will close this issue.

fidencio commented 3 years ago

This issue is being automatically closed as Kata Containers 1.x has now reached EOL (End of Life). This means it is no longer being maintained.

Important:

All users should switch to the latest Kata Containers 2.x release to ensure they are using a maintained release that contains the latest security fixes, performance improvements and new features.

This decision was discussed by the @kata-containers/architecture-committee and has been announced via the Kata Containers mailing list:

If you believe this issue still applies to Kata Containers 2.x, please open an issue against the Kata Containers 2.x repository, pointing to this one, providing details to allow us to migrate it.

kata-containers / packaging

experimental kernel in build-kernel.sh - is fine or clean this in feature? #1066