search

kata-containers / packaging

Kata Containers version 1.x packaging (for version 2.x see https://github.com/kata-containers/kata-containers).
https://katacontainers.io/
Apache License 2.0
119 stars 92 forks source link

kata-deploy: add ACRN runtime to Docker configuration #1077

Closed gvancuts closed 4 years ago

gvancuts commented 4 years ago

Add an ACRN runtime ('kata-acrn') to the Docker configuration (daemon.json)

Signed-off-by: Geoffroy Van Cutsem geoffroy.vancutsem@intel.com

gvancuts commented 4 years ago

@vijaydhanraj FYI

devimc commented 4 years ago

thanks @gvancuts - please fix the commit message https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format

https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#examples

gvancuts commented 4 years ago

thanks @gvancuts - please fix the commit message https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format

https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#examples

I have added a Fixes: line in my commit message. Was there something else that I needed to change? (I don't think so... but double-checking)

devimc commented 4 years ago

/test

devimc commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
krsna1729 commented 4 years ago

The formatting seems off for previous blocks. Also is there a closing bracket missing?

gvancuts commented 4 years ago

The formatting seems off for previous blocks. Also is there a closing bracket missing?

Ouch... indeed... good catch. Should be fixed now.

Btw, is there an easy way I can test this on my system (sorry, not very familiar with how this all works together). Thanks!

krsna1729 commented 4 years ago

https://github.com/kata-containers/packaging/tree/master/kata-deploy#docker-quick-start you can mount your version of the script to test. /cc @egernst

gvancuts commented 4 years ago

https://github.com/kata-containers/packaging/tree/master/kata-deploy#docker-quick-start you can mount your version of the script to test. /cc @egernst

Done, I tested this using

$ sudo docker run -v /home/acrn/work/packaging/kata-deploy/scripts:/opt/kata-artifacts/scripts -v /opt/kata:/opt/kata -v /var/run/dbus:/var/run/dbus -v /run/systemd:/run/systemd -v /etc/docker:/etc/docker -it katadocker/kata-deploy kata-deploy-docker install

And Docker could see and successfully use this new kata-acrn runtime (after a couple of minor tweaks, unrelated to this PR).

amshinde commented 4 years ago

/test kata-deploy

gvancuts commented 4 years ago

Just to make sure, since I'm not a regular contributor to this project, do I still need to do anything for this PR or it's on track?

devimc commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
devimc commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).