search

kata-containers / packaging

Kata Containers version 1.x packaging (for version 2.x see https://github.com/kata-containers/kata-containers).
https://katacontainers.io/
Apache License 2.0
119 stars 92 forks source link

kata-deploy: add PodOverhead to RuntimeClasses #1079

Closed egernst closed 4 years ago

egernst commented 4 years ago

As of 1.18 this feature is Beta. We will need this applied if we are running utilizing sandbox cgroups only (this should really be default).

We'll want to iterate on the most appropriate values going forward, but this is a safe starting point.

Fixes: #995

Signed-off-by: Eric Ernst eric@amperecomputing.com

egernst commented 4 years ago

/test

/cc @likebreath @amshinde @jcvenegas PTAL

likebreath commented 4 years ago

LGTM. Thanks, @egernst . Can't ACK though. ;)

likebreath commented 4 years ago

Also, I am wondering how will the CI cover the changes to kata-deploy? I thought it is now only validated manually (during each release).

egernst commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
egernst commented 4 years ago

/test kata-deploy

egernst commented 4 years ago

@jcvenegas You have any insights into the obs failure?

jcvenegas commented 4 years ago

@egernst not really, @devimc is having some similar issues with another PR, I think he is debugging what grep is making file this.

egernst commented 4 years ago

@jcvenegas @devimc @chavafg : any updates on the failing job? I'd like to get this PR landed.

If necessary, should we mark that failing job non-required?

chavafg commented 4 years ago

seems that @devimc fixed in #1082, merged it and let's restart this one.

chavafg commented 4 years ago

/test kata-deploy

chavafg commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).