search

kata-containers / packaging

Kata Containers version 1.x packaging (for version 2.x see https://github.com/kata-containers/kata-containers).
https://katacontainers.io/
Apache License 2.0
119 stars 92 forks source link

Whitelist CONFIG_MEMCG_SWAP_ENABLED #1123

Closed skaegi closed 3 years ago

skaegi commented 4 years ago

See https://cateee.net/lkddb/web-lkddb/MEMCG_SWAP_ENABLED.html Whitelisting this config item provides compatibility with 5.8+ kernels.

Fixes #1122

devimc commented 4 years ago

btw - The sign-off is missing.

skaegi commented 4 years ago

btw - The sign-off is missing.

Yes -- sigh -- my bad. I tried a force update and added it. See https://github.com/kata-containers/packaging/pull/1123/commits/3d36955c53c2ef7d8c52643d2031015eec4105af

That did not however re-trigger the DCO Check. Is there a way to re-trigger this all?

devimc commented 4 years ago

@skaegi same error, ptal https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#general-format

Signed-off-by: Contributors Name <contributor@foo.com>
jodh-intel commented 4 years ago

@skaegi - Please can you rework the commit message to be something like the following and the git push -f to re-trigger the failing DCO check:

kernel: Whitelist CONFIG_MEMCG_SWAP_ENABLED

See https://cateee.net/lkddb/web-lkddb/MEMCG_SWAP_ENABLED.html
Whitelisting this config item provides compatibility with 5.8+ kernels.

Fixes: #1122.

Signed-Off-By: Simon Kaegi <simon.kaegi@gmail.com>
skaegi commented 4 years ago

Signed-Off-By: Simon Kaegi simon.kaegi@gmail.com

Thanks @jodh-intel -- I swear I will never screw this up again ;)

devimc commented 4 years ago

/test

devimc commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
amshinde commented 3 years ago

/test-ubuntu

fidencio commented 3 years ago

Folks, this PR has been stale and I'm closing it as we're walking towards the final 1.13.0 release of the kata-containers-1.x. From now on, all the development will happen as part of https://github.com/kata-containers/kata-containers/ and fixes should be provided to that repo.

Thanks a lot for your contribution, we're sorry that for some reason it got stale, and we hope to see you around for new adventures in the kata-containers-2.x land.