search

kata-containers / packaging

Kata Containers version 1.x packaging (for version 2.x see https://github.com/kata-containers/kata-containers).
https://katacontainers.io/
Apache License 2.0
119 stars 92 forks source link

config: remove CONFIG_REFCOUNT_FULL in config.base for arm #1169

Closed jongwu closed 3 years ago

jongwu commented 4 years ago

CONFIG_REFCOUN_FULL is gone since v5.5, so remove it here as kernel for virtio-fs base on v5.6.

Fixes: #1168 Signed-off-by: Jianyong.Wu jianyong.wu@arm.com

@devimc @jodh-intel

fidencio commented 4 years ago

/test

fidencio commented 4 years ago

Sorry about prematurely running /test. Our DCO check is failing because of:

  3047df809ea237bbd68e3d6e1819c42592e97452    Expected "Jianyong Wu <jianyong.wu@arm.com>", but got "Jianyong.Wu <jianyong.wu@arm.com>".
jongwu commented 4 years ago

Thanks @fidencio, having reposted it. this commit has merged to kata-container-2.0

fidencio commented 4 years ago

/test

fidencio commented 4 years ago

Thanks @fidencio, having reposted it. this commit has merged to kata-container-2.0

If the exactly same commit was merged in 2.0, we have a discrepancy in our scripts. @jodh-intel, are you aware of something different in 2.0 and this branch about the DCO checks?

jongwu commented 4 years ago

sorry @fidencio -, I make mistake, this PR has not posted to kata-2.0. It's the PR has merged into kata-2.0.

fidencio commented 4 years ago

sorry @fidencio -, I make mistake, this PR has not posted to kata-2.0. It's the PR has merged into kata-2.0.

Okay, no problem. :-). Thanks!

jongwu commented 4 years ago

Hello @jodh-intel @devimc - need test for this.

devimc commented 4 years ago

/test

jodh-intel commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
amshinde commented 3 years ago

@jongwu Need a bump in kata_config_version here

jongwu commented 3 years ago

thanks @amshinde , done.

jongwu commented 3 years ago

/test

jongwu commented 3 years ago

/test

jongwu commented 3 years ago

/test

jongwu commented 3 years ago

Hi @lifupan @amshinde, can you help trigger the tests? thanks.

lifupan commented 3 years ago

/retest

jongwu commented 3 years ago

hello @jodh-intel @devimc , it seems the CI is broken as it can't be triggered.

devimc commented 3 years ago

@jongwu can you rebase and try again ?

jodh-intel commented 3 years ago

/test-snap

jodh-intel commented 3 years ago

/retest-snap

jodh-intel commented 3 years ago

@devimc ^ looks like the snap build isn't triggering ;(

devimc commented 3 years ago

@jodh-intel you can't trigger github actions using comments :sweat_smile:

devimc commented 3 years ago

please ignore the snap CI, I still need to backport a patch to fix yq

jodh-intel commented 3 years ago

@devimc - Doh! ;) We need to remove the entry from https://github.com/kata-containers/community/wiki/Controlling-the-CI.

jongwu commented 3 years ago

/test

jongwu commented 3 years ago

hello @jodh-intel @devimc , this PR blocked by CI for a long time. Is there any process?

jodh-intel commented 3 years ago

@jongwu - I've restarted the failing CI's, so ... :crossed_fingers: it works this time... :smile:

/AzurePipelines run

jodh-intel commented 3 years ago

@jongwu - the static checks are failing:

ERROR: Required SPDX license header check ('SPDX-License-Identifier: Apache-2.0') failed for the following files:

kernel/configs/fragments/arm64/acpi.conf
kernel/configs/fragments/arm64/base.conf

You can either add that header, or you might want to raise a 1.x PR on the tests repo to make the static checker ignore files below kernel/configs/. We already did that for 2.x so you could raise a PR very similar to:

jongwu commented 3 years ago

thanks @jodh-intel -, I will raise a PR to fix it.

jongwu commented 3 years ago

hello @jodh-intel @devimc, any comments?

jodh-intel commented 3 years ago

/test

jodh-intel commented 3 years ago

/AzurePipelines run

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 2 pipeline(s).
jongwu commented 3 years ago

/AzurePipelines run

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 2 pipeline(s).
jongwu commented 3 years ago

/AzurePipelines run

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 2 pipeline(s).
jongwu commented 3 years ago

/test