search

kata-containers / packaging

Kata Containers version 1.x packaging (for version 2.x see https://github.com/kata-containers/kata-containers).
https://katacontainers.io/
Apache License 2.0
119 stars 92 forks source link

[DNM] qemu: Fix virtiofsd crash on RHCOS #1177

Closed wainersm closed 3 years ago

wainersm commented 4 years ago

This will fix a failure of virtiofsd trying to mount a directory on temporary filesystem that might be read-only. It is the case in RHCOS which has virtiofsd crashing with "operation not permitted".

Cherry-picked the following commit from QEMU:

Fixes #1176

Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com

wainersm commented 4 years ago

I tested the fix proposed on this PR on Openshift 4.6. Worked out!

wainersm commented 4 years ago

@c3d You may be interested on reviewing this.

wainersm commented 4 years ago

thanks @wainersm - can you forward port it ?

Interesting, I thought we were already using QEMU 5.1 on 2.x. Sure, I will forward port it then.

@devimc are you able to trigger the obs-packaging-ci job on my behalf?

Thanks for the review!

wainersm commented 4 years ago

The reason why I moved to Do Not Merge:

While forward porting to 2.x I realized that the patch does not apply on upstream QEMU 5.0 tree, whereas on virtio-fs's QEMU (branch qemu5.0-virtiofs-with51bits-dax) it does. I will investigate how to handle that conflict.

devimc commented 4 years ago

/AzurePipelines run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 2 pipeline(s).
wainersm commented 3 years ago

I updated the patch so that the fix won't be applied on our build of the upstream QEMU 5.0.0.

fidencio commented 3 years ago

As it's a do-not-merge, let's close it as it won't make its way into the final 1.13.0 release.