search

kata-containers / qemu

Kata containers QEMU
Other
22 stars 19 forks source link

configure: Add configure script #1

Closed devimc closed 6 years ago

devimc commented 6 years ago

this script enables a little set of qemu features needed to run virtual containers

Signed-off-by: Julio Montes julio.montes@intel.com

devimc commented 6 years ago

@sameo @bergwolf @gnawux @laijs please take a look

devimc commented 6 years ago

/cc @sameo @bergwolf @gnawux @laijs

sameo commented 6 years ago

LGTM

sameo commented 6 years ago

@bergwolf Could you please review?

devimc commented 6 years ago

@bergwolf yout have to patch the configure

devimc commented 6 years ago

@bergwolf you have to patch the configure file https://github.com/kata-containers/qemu/pull/1/files#diff-e2d5a00791bce9a01f99bc6fd613a39d

egernst commented 6 years ago

@devimc - can you clarify why the patching is needed for configure, compared to just using a set of "supported" flags? I have been able to build successfully when not patching by updating the flag set.

devimc commented 6 years ago

@bergwolf @egernst PR updated

bergwolf commented 6 years ago

@devimc please drop the commit configure: don't fail in case of unknown option. configure script SHOULD fail on unknown options.

devimc commented 6 years ago

@bergwolf what do you propose to have a script compatible between qemu versions? or should we have different script for each version ?

bergwolf commented 6 years ago

@devimc I see the PR is raised against stable-2.7 branch. Is there particular reason to pick the specific qemu version? Or is it just a random stable version?

devimc commented 6 years ago

@bergwolf stable version, and works with CRIO

devimc commented 6 years ago

@bergwolf changes applied, thanks

devimc commented 6 years ago

@bergwolf fixed, thanks

jodh-intel commented 6 years ago

lgtm.

But I do wonder if we should call it just configure-qemu.sh (or similar) and have the script check the value of arch(1) to add arch-specific flags (like "--target-list=x86_64-softmmu").

devimc commented 6 years ago

@jodh-intel good point, @bergwolf what do you think?, configure options are the same for other architectures ? or should we have a script for each architecture?

bergwolf commented 6 years ago

@devimc I agree with @jodh-intel. You can define a arch variable in the script and make it work with different architectures.

devimc commented 6 years ago

@bergwolf @jodh-intel changes applied, thanks

jodh-intel commented 6 years ago

lgtm

devimc commented 6 years ago

@jodh-intel @bergwolf fixed

jodh-intel commented 6 years ago

lgtm

bergwolf commented 6 years ago

lgtm

thanks @devimc