Closed jcvenegas closed 6 years ago
mmm have you tried to disable it with nostatic-prt
?
I'd prefer to see nostatic-prt
in the runtime than here ..
@devimc I tried (see https://github.com/kata-containers/runtime/pull/676/commits/f61a15860b593fbafea4f74a445080e5155416c4 ).
This flag was introduce in qemu-lite patches. If we pass the flag to qemu without qemu-lite patches, it will fail becasue not recognize it (see https://github.com/kata-containers/runtime/pull/676#issuecomment-417571635). So better enabled explicitly that disable it explicitly and break runtime able to run non qemu-lite builds.
LGTM. Thanks @jcvenegas !
lgtm
Let's get an ack from the authors though...
/cc @chao-p, @yangzhon
LGTM
Thanks @chao-p!
static_ptr has some conflicts with virtio-rng devices.
This can be disabled but if the flag to disable is used with qemu verions that does not provide this flag, qemu will fail.
Lets keep the original behavior, and enabled explicitly.
See: https://github.com/kata-containers/runtime/issues/445
Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com