kata-containers / runtime

Kata Containers version 1.x runtime (for version 2.x see https://github.com/kata-containers/kata-containers).

https://katacontainers.io/

Apache License 2.0

2.1k stars 377 forks source link

cli: Fix the incorrect default hostname "runc" #3158

Closed LiangZhou-CTY closed 3 years ago

LiangZhou-CTY commented 3 years ago

When use "kata-runtime spec" to generate config.json, the default hostname is "runc", which is not correct. The proper one should be "kata", instead of "runc".

Fixes: #3157

Signed-off-by: Liang Zhou zhoul110@chinatelecom.cn

devimc commented 3 years ago

@LiangZhou-CTY thanks for the PR, silly question: are you still using kata 1.x ? may be you want to raise this in the 2.x repo ?

LiangZhou-CTY commented 3 years ago

@LiangZhou-CTY thanks for the PR, silly question: are you still using kata 1.x ? may be you want to raise this in the 2.x repo ?

Yes I will check if 2.x has the similar issue or not but AFAIK seems that 2.x does not support “spec” command anymore...

fidencio commented 3 years ago

/test

codecov[bot] commented 3 years ago

Codecov Report

Merging #3158 (ff4e492) into master (299b16f) will decrease coverage by 0.99%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3158      +/-   ##
==========================================
- Coverage   50.26%   49.27%   -1.00%     
==========================================
  Files         120      120              
  Lines       26873    16426   -10447     
==========================================
- Hits        13508     8094    -5414     
+ Misses      11589     7240    -4349     
+ Partials     1776     1092     -684