kata-containers / runtime

Kata Containers version 1.x runtime (for version 2.x see https://github.com/kata-containers/kata-containers).

https://katacontainers.io/

Apache License 2.0

2.1k stars 376 forks source link

Update version number of the agent for 1.13.0-alpha0 #3171

Closed c3d closed 3 years ago

c3d commented 3 years ago

Having the wrong agent version there causes the following error: https://github.com/kata-containers/osbuilder/pull/520#issuecomment-832874777

ERROR: rootfs build failed
INFO: ERROR: test failed
INFO: rootfs:
total 8
drwxr-xr-x 17 root root 4096 May  5 17:22 clearlinux_rootfs
drwxr-xr-x 21 root root 4096 May  5 17:22 ubuntu_rootfs
INFO: images:
total 0
INFO: running: /home/runner/work/osbuilder/osbuilder/../tests/cmd/kata-manager/kata-manager.sh configure-image
file not found: /home/runner/work/osbuilder/osbuilder/../tests/cmd/kata-manager/kata-manager.sh at /usr/bin/chronic line 66.

Fixes: #3170

Signed-off-by: Christophe de Dinechin dinechin@redhat.com

c3d commented 3 years ago

/test-ubuntu

codecov[bot] commented 3 years ago

Codecov Report

Merging #3171 (abbef7f) into master (04f2983) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3171   +/-   ##
=======================================
  Coverage   50.23%   50.23%           
=======================================
  Files         120      120           
  Lines       16078    16078           
=======================================
  Hits         8076     8076           
  Misses       6908     6908           
  Partials     1094     1094

fidencio commented 3 years ago

Either this PR doesn't solve the issue or "Depends-on" is not working on 1.x branches, as https://github.com/kata-containers/osbuilder/pull/520 keeps failing even with this one.

c3d commented 3 years ago

@GabyCT @wainersm @devimc Do you know if the "Depends-on:" works for a PR that changes the version.yaml? I'm trying to understand the logic of how versions are extracted for testing.

fidencio commented 3 years ago

This issue is being automatically closed as Kata Containers 1.x has now reached EOL (End of Life). This means it is no longer being maintained.

Important:

All users should switch to the latest Kata Containers 2.x release to ensure they are using a maintained release that contains the latest security fixes, performance improvements and new features.

This decision was discussed by the @kata-containers/architecture-committee and has been announced via the Kata Containers mailing list:

If you believe this issue still applies to Kata Containers 2.x, please open an issue against the Kata Containers 2.x repository, pointing to this one, providing details to allow us to migrate it.