Closed linxiulei closed 5 years ago
@malc0lm, @linxiulei - can you provide details to reproduce on Kata? We don't use hyper start in Kata. It should be specific to the new gRPC protocol / agent.
I had a feeling we had a test for this, but I cannot locate it. @GabyCT @devimc - any memories of this? If we don't have an existing test, can we add one with this PR maybe to check the fix is working? :-)
This should not be posted on this repo since the issue is related to Clear Containers (using cc-runtime
in the Docker command). That being said, if this is a Clear Containers issue, you should switch to Kata Containers to get some support when running into issues.
Close this since it is not related to kata.
Description of problem
Create a container with an env file, which has size bigger than 10240 bytes, cmd like
then
it has no response anymore
Expected result
it's supposed to run normally
Actual result
docker cmd no response
Meta details
Running
cc-collect-data.sh
version3.0.22 (commit 4b569ac)
at2018-06-12.17:13:02.305371930+0800
.Runtime is
/usr/bin/cc-runtime
.cc-env
Output of "
/usr/bin/cc-runtime cc-env
":Runtime config files
Runtime default config files
Runtime config file contents
Output of "
cat "/etc/clear-containers/configuration.toml"
":Output of "
cat "/usr/share/defaults/clear-containers/configuration.toml"
":Agent
version:
Logfiles
Runtime logs
Recent runtime problems found in system journal:
Proxy logs
Recent proxy problems found in system journal:
Shim logs
No recent shim problems found in system journal.
Container manager details
Have
docker
Docker
Output of "
docker version
":Output of "
docker info
":Output of "
systemctl show docker
":No
kubectl
Packages
No
dpkg
Haverpm
Output of "rpm -qa|egrep "(cc-oci-runtime|cc-proxy|cc-runtime|cc-shim|kata-proxy|kata-runtime|kata-shim|clear-containers-image|linux-container|qemu-lite|qemu-system-x86)"
":Note1: I was using ClearContainer-3.0, however it is reproducible with kata
Note2: Actually it involves two bugs
1) https://github.com/containerd/containerd/pull/872
it's been fixed
2) https://github.com/kata-containers/runtime/blob/ca9f7abba96e5c4db734673b9e7d870076d715e2/virtcontainers/pkg/hyperstart/hyperstart.go#L394
Here it checks length if bigger than 10240 , which is no longer needed (pls correct me if I am wrong). Agent that receives message at other side have no length limit if it is smaller than UInt32