search

kata-containers / tests

Kata Containers tests, CI, and metrics
https://katacontainers.io/
Apache License 2.0
141 stars 195 forks source link

Run commit message checks in GHA only, thus remove them from tests #4425

Open Jakob-Naucke opened 2 years ago

Jakob-Naucke commented 2 years ago

@fidencio we run commit message tests from CI and in GHA, but these two are written independently, I was wondering the same thing :smile:

Ouch, why do we do that? :-(

This was introduced in https://github.com/kata-containers/kata-containers/pull/486. I wonder whether the checks should be removed from our CI jobs and the tests repository altogether.

I think so, that's something we should clean up at at some point.

Originally posted by @Jakob-Naucke & @fidencio in https://github.com/kata-containers/kata-containers/issues/3565#issuecomment-1027701309

bookinabox commented 2 years ago

With #4878, I think this can be closed.