ci.ocp: Improve the service-up detection

kata-containers / tests

Kata Containers tests, CI, and metrics

https://katacontainers.io/

Apache License 2.0

139 stars 196 forks source link

ci.ocp: Improve the service-up detection #5807

Closed ldoktor closed 9 months ago

ldoktor commented 9 months ago

waiting for the first response is not sufficient as OCP returns html page without error even when the route is not yet established describing the issue (why it doesn't reply with 500?). Waiting for the correct output should do better.

ldoktor commented 9 months ago

I tested (similar) version here: https://github.com/openshift/release/pull/48473 seems to work well.

ldoktor commented 9 months ago

@wainersm @gkurz could you please review this? It significantly decreases the stability of the CI pipeline.

stevenhorsman commented 9 months ago

Hi Lukas - is there a plan to move this openshift testing into the kata-containers repo as the tests repo is deprecated?

ldoktor commented 9 months ago

Changes:

Using "check_cmd" variable to emphasize the waitForProcess command
Split into 2 commits (fix and extra debug output)
Capture output of all curl attempts and log them in case of a failure
Added "Fixes" to the first commit

Not changed:

Kept the "HTTP server is working" message as it was there before this PR

tbuskey commented 9 months ago

/lgtm

gkurz commented 9 months ago

/test

gkurz commented 9 months ago

Hi Lukas - is there a plan to move this openshift testing into the kata-containers repo as the tests repo is deprecated?

@stevenhorsman IIUC Lukas is using the test repo as a guinea pig. When everything works, the openshift testing will go the the kata-containers repo like the rest.

ldoktor commented 9 months ago

Hi Lukas - is there a plan to move this openshift testing into the kata-containers repo as the tests repo is deprecated?

@stevenhorsman IIUC Lukas is using the test repo as a guinea pig. When everything works, the openshift testing will go the the kata-containers repo like the rest.

Most of the work is done, now I'm waiting for the 4.13 pipeline issue to be resolved so the https://github.com/openshift/release/pull/48435 can be merged (we actually think about merging it with the failure, depends on the reviewers). Anyway this patchset will have to be backported to kata-containers, I'll take care of it once it's ready. Now it's important to ensure the pipeline works again.