Lily58 Pro footprint issues

Maarrk commented 2 years ago

When ordering manufacturing of the Pro PCBs, I ran into some issues:

the MX hotswap socket holes have a 0.1mm hole inside them which shouldn't be there (see screenshot)
all footprints reference Lily58-footprint library instead of Lily58_Pro-footprint
the switch footprints reference CherryMX_KailhLowProfile_Hotswap_Edge, I guess they should be MX_Choc_Hotswap from the Pro library

The issue with the extra holes is most severe, because having holes smaller than 0.3mm in the drill file raises cost of PCB manufacturing. Even though they don't actually make sense, since they are inside bigger holes.

I don't know how the footprint libraries got so mixed up. If you don't have it sorted on your machine waiting to be commited, I'd be happy to submit a PR.

extra hole

sungo commented 2 years ago

@Maarrk since you've not gotten a response here, can I talk you into tossing the repaired kicads up someplace?

Maarrk commented 2 years ago

@sungo I'm sorry, but I don't have these anymore. I'd need to start from scratch, and now I'm already on KiCad 6...

Should've just done the PR right away 😢

sungo commented 2 years ago

@Maarrk no worries. Thanks for pointing out the issues. I'm glad to not get caught unaware and I need to learn kicad anyway

kata0510 / Lily58

Lily58 Pro footprint issues #31