search

katabami83 / gakumas_contest_simulator

8 stars 2 forks source link

Deprecate `p_items` URL param #11

Open surisuririsu opened 2 months ago

surisuririsu commented 2 months ago

Hi, I've updated the URL builder in Gakumas Tools to conform to the ordering rules of your new p_item_ids param, so p_items won't be used anymore.

I don't think anyone else is using this, so you can probably deprecate it now. https://github.com/katabami83/gakumas_contest_simulator/blob/a50b2e1e422e7874f45c2db7940accfeaa1edc61/src/components/modules/common/PItemSet.vue#L54-L64

surisuririsu commented 2 months ago

Also seems like this split isn't needed anymore, since only 1 p_idol id is required now. https://github.com/katabami83/gakumas_contest_simulator/blob/02a57448e56950dc01da9328e7e569c857806942/src/components/modules/common/PIdolSelector.vue#L140