katalyst / koi

Administration tools for Rails applications
https://github.com/katalyst/koi
MIT License
9 stars 4 forks source link

Add support for type `attachment` in scaffold generators #540

Closed hasarindaKI closed 1 year ago

sfnelson commented 1 year ago

I don't think there's enough benefit here to justify inclusion in our generators. The image check doesn't seem like a robust approach, and there are no specs to prevent regressions. The addition implies that a user can add an attachment using the generator and everything is ready to go, which is not the case as there would likely be changes to the views and the models in order to meet our best practices.

Happy to consider a PR once we have more experience.