search

kataras / neffos.js

Node.js and Browser support for the neffos real-time framework written in Typescript.
MIT License
42 stars 16 forks source link

fix(neffos.js): only conditionally import node websocket dependency #33

Open alpjor opened 10 months ago

kataras commented 10 months ago

Is it tested @alpjor?

alpjor commented 10 months ago

@kataras I've tested this version running both in browser contexts and in a node env. I'm a little concerned about changing the target: and module: because I don't know if that'll change the support for older browsers where I haven't done any testing, but those changes where necessary to get access to the await import( syntax to conditionally load the dependency. It's a bit weird though, because before the PR you accepted of mine about the nonce, the conditional load code was there and was working, but after my PR it was gone. I think there might've been some changes in the dist folder that weren't reflected in the src folder. I looked at the compiled code in the dist folder from the commit before my change and it doesn't seem to 100% match the src code at the time (es5 and min versions were different from plain js too). Maybe a bad push? lmk what you think and thanks for looking at it. Either way, this code does work for me in my fork in all my testing in modern browser environments, I hope it helps here too