search

kataras / rizla

:eyes: Rizla builds, runs and monitors your Go Applications with ease. See https://github.com/kataras/iris-cli for Iris users.
MIT License
190 stars 17 forks source link

processes not been killed #8

Closed oliveagle closed 6 years ago

oliveagle commented 7 years ago

OS: arch linux go: 1.8.1

oliveag+ 12379  0.0  0.0 208760 10660 pts/7    Sl+  10:34   0:00 ./main
oliveag+ 12603  0.2  0.1 128208 12572 pts/7    Sl+  10:34   0:00 ./main
       // here. proc.Pid > 0 
    if !isMac {
        err = proc.Release()
        if err != nil {
            return nil // to prevent throw an error if the proc is not yet started correctly (= previous build error)
        }
    }
        // now proc.Pid is always -1
    if proc.Pid <= 0 {
        return nil
    }
kataras commented 6 years ago

@oliveagle It's fixed with https://github.com/kataras/rizla/commit/55dc5f9e603825885f80de5c69519efe11047c32 Thanks for the report