search

kate-hall / alexa-icomfort

Alexa Smart Home Skill for Lennox iComfort Thermostat
MIT License
22 stars 7 forks source link

Code Preparation Question #20

Closed StarfighterJ closed 6 years ago

StarfighterJ commented 6 years ago

Save your changes and zip the contents of the src folder. Do NOT include the src folder itself, just the contents! Are we Suppose to include the node_modules Folder in the Zip file?

kate-hall commented 6 years ago

Yep! Include the node_modules.

Sorry for my slowness, I'm still working on a v3 fix, if you want to try out what I've got so far it's in this branch: https://github.com/kate-hall/alexa-icomfort/tree/v3

Note that I haven't finished the "Alexa, turn up temperature" style commands, only setting by exact degree. There have been some massive changes in how Alexa interfaces with thermostats and mapping it to Lennox's (slightly) clunky system is tricky.

StarfighterJ commented 6 years ago

I played around with the V3 new code still can't discover it Also I ran a LAMBDA test and got this result See attached: 2018-01-11

jwsattler commented 6 years ago

Hi Kate, firstly - a great initiative, thanks!

I've followed all the instructions and release notes, and think I'm close to getting it working. I can successfully do a lambda test with your earlier code branch (although if I try with the v3 branch I get the same error as StarfighterJ).

The one issue I have is with device discovery. Amazon no longer allows new deployments of v2 smart home skill APIs. I can only deploy v3. Any thoughts on if this is likely to be the issue with device discovery? In which case I guess I should wait until you've found time to iron out a new release?

Thanks again for the great work.

cmarkovitz commented 6 years ago

@jwsattler if you try it with the new code - @kate-hall just merged a branch - it will work with v3 AND multiple zones

StarfighterJ commented 6 years ago

I see the V3 zip to download but it hasn't been updated since 27 DEC 2017 has this been updated since my last test?

kate-hall commented 6 years ago

@StarfighterJ I'm closing this ticket and we can correspond in the newer one!