kate-hall / alexa-icomfort

Alexa Smart Home Skill for Lennox iComfort Thermostat
MIT License
22 stars 7 forks source link

icomfort V3 #22

Closed StarfighterJ closed 6 years ago

StarfighterJ commented 6 years ago

Hi Kate is the new V3 dated 27 December 2017 the latest in the Download area Good to go now?

barwin commented 6 years ago

@StarfighterJ - the master branch of this repo is v3-ready. Just 'clone or download' the repo and you should be able to follow Kate's setup instructions from there.

image

StarfighterJ commented 6 years ago

I can't get it to Discover and when I run a Lamba test I get this: Please help What am I doing wrong. FYI in the Development the are where to Put Privacy Policy: https://ve0kyj5tp5.execute-api.us-east-1.amazonaws.com/test/PrivacyPolicy (any value is fine) is no longer there? 2018-04-05

kate-hall commented 6 years ago

What's in the test you're running? I see that it's called LennoxAdapter, but without seeing that code I'm clueless as to why it's failing.

Also: the setup instructions have changed significantly with this version, did you delete the original and start over? That might be the best way of ensuring the correct setup.

kate-hall commented 6 years ago

@StarfighterJ I have a feeling you're using the default Discovery test JSON object in the Lambda...which is outdated.

Can you try this instead (replace the code in LennoxAdapter > Configure test events with the following):

{ 
    "directive": { 
        "header": {
            "namespace": "Alexa.Discovery",
            "name": "Discover",
            "payloadVersion": "3",
            "messageId": "4d92adf0-881b-4507-90bb-e5b8f5385249" 
        },
        "payload": { 
            "scope": {
                "type": "BearerToken",
                "token": "AnythingCanBeAToken"
            }

        } 
    } 
}

Run the test again, and post the full execution results. I just removed my own device and reran discovery and was able to find my thermostat, so I don't think the code's broken.

StarfighterJ commented 6 years ago

Holy Smoke I deleted everything and Started over and every thing works now Thanks a Bunch Kate

kate-hall commented 6 years ago

Hooray! Glad you got it working!