search

katemihalikova / ion-datetime-picker

Date and/or time picker for awesome Ionic framework
MIT License
168 stars 101 forks source link

Order of months in the month list displayed in the select box is wrong. #20

Closed himavijayachandran closed 8 years ago

himavijayachandran commented 8 years ago

Order of months in the month list displayed in the select box is wrong. November and December come in between February and March.

katemihalikova commented 8 years ago

Working fine on all of my devices, please provide more details.

himavijayachandran commented 8 years ago

I want to develop an application that should work from at least android 4.4 on wards.

katemihalikova commented 8 years ago

Thanks for your reply, but I need to isolate your problem and thus I need a simple example snippet extracted from your app that demonstrates your problem. You can start with the codepen demo. Feel free to reopen this issue when you are done.

ofershap commented 8 years ago

image

Happens to me too, both on web and on IOS months sorting is wrong

katemihalikova commented 8 years ago

Could you please add a codepen demonstrating your issue or at least your ionic and angular version? Thanks.

ofershap commented 8 years ago

Do you have a working example in codepen that i could see and compare with my code? I am using Ionic 1.7.15 angular v1.3.13

The problem is with ordering the month list, i tried fixing it by myslef and failed to do so, maybe you can suggest This line: Should have an " | OrderBy: Number(index) " or something alike. inside the ng-options (i guess its not index that should be inside the orderBy)

On Wed, Jun 15, 2016 at 2:14 PM, Kate Miháliková notifications@github.com wrote:

Could you please add a codepen demonstrating your issue or at least your ionic and angular version? Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/katemihalikova/ion-datetime-picker/issues/20#issuecomment-226158051, or mute the thread https://github.com/notifications/unsubscribe/ACeEBr1PfSxS1qJGbA7ESxQMUsJm5icSks5qL96ygaJpZM4IPm9r .

בברכה, עופר שפירא 054-4978633 http://www.dailys.co.il/

katemihalikova commented 8 years ago

There is a demo in readme: http://codepen.io/katemihalikova/pen/dYvjzP When I get some free time I'm going to look into it if I'm able to reproduce with your angular version.

katemihalikova commented 8 years ago

OK I've reproduced it recently with the angular version you are using. I will try to come up with a solution soon.

Workaround: use ionic >=1.1.0 OR angular >=1.4.0

katemihalikova commented 8 years ago

Fixed by 4c8611f and released as 0.3.1.

ofershap commented 8 years ago

Thanks!!