search

katerakelly / oyster

Implementation of Efficient Off-policy Meta-learning via Probabilistic Context Variables (PEARL)
MIT License
472 stars 125 forks source link

Typos in simple_replay_buffer.py ? #12

Open duongnhatthang opened 4 years ago

duongnhatthang commented 4 years ago

Is this a typo ? should you change episode_starts => _episode_starts

https://github.com/katerakelly/oyster/blob/3a4777b95e1772a74142c49a33b5ca1db768d140/rlkit/data_management/simple_replay_buffer.py#L79

katerakelly commented 4 years ago

Yes, this only affects the recurrent encoder option, which is currently broken. See Issue 13