katerinakazantseva / strainy

Graph-based assembly phasing
Other
43 stars 4 forks source link

Don't use wildcard imports + parameters naming #32

Open mikolmogorov opened 1 year ago

mikolmogorov commented 1 year ago

Don't use wildcard imports like from metaphase.XX import *. This makes the code difficult to read and prone to errors.

Instead, either use import metaphase.XX as YYm and then use YY.funcionZ(), or import specific functions as from metaphase.XX impot functionZ.

This in particular important for the parameters in params.py - I suggest to either use module import and then do params.PARAM_NAME or have a single dictionary with all parameters that you can import.

In addition, parameters should be given informative names (e.g. strong_cluster_min_reads, but not I or R.