katescarth / literary-halifax-mobile-app

Literary Halifax Mobile App
GNU General Public License v3.0
0 stars 0 forks source link

Tab bar shadow #5

Open David-Owen-Walker opened 7 years ago

David-Owen-Walker commented 7 years ago

The tab bar is displayed as though it is an extension of the nav bar: tab_bar

Note that this effect is mostly because of the common color.

The side menu casts a shadow on the content in the app:

menu_shadow_correct

This is correct and necessary because the display cards cast shadows. Since the menu is displayed above them, it would be jarring to not have a shadow.

However, the menu is also displayed over the tab bar. This, on its own, is kind of weird; the tab bar and nav bar appear to be on the same level, the nav bar and and side menu appear to be on the same level, and the side menu and tab bar DON'T appear to be on the same level. This gets very jarring when the side menu is open while the map tab is selected, because it creates a division that wasn't there before the side menu was opened.

menu_shadow_incorrect

We need a consistent conceptual design for the level order (z-index) of the tab bar, nav bar, and side menu, and both the layering and shadows need to reflect it