search

katharsis-project / katharsis-framework

Katharsis adds powerful layer for RESTful endpoints providing implementenation of JSON:API standard
http://katharsis.io
Apache License 2.0
135 stars 65 forks source link

Katharsis to support use of Spring's dispatcherServletFilter #36

Open masterspambot opened 8 years ago

masterspambot commented 8 years ago

From @bduisenov on June 27, 2016 8:9

Hi. In katharsis spring integration the KatharsisFilter2 is been used to handle requests to jsonapi. Could you tell why Filter has been chosen instead of HandlerMapping & HandlerAdaptor. From my perspective using spring's dispatcherServlet would be more beneficial, as the dispatching process also goes through pre-post processors f.ex.

Copied from original issue: katharsis-project/katharsis-spring#32

masterspambot commented 8 years ago

From @meshuga on June 27, 2016 18:46

I totally agree with you. At the beginning I created a filter because it fulfilled my needs and allowed for creating a Spring controller within the same path. I don't think it's a big job to create a separate servlet which could be used within Spring. Actually, similar thing had been done in https://github.com/katharsis-project/katharsis-servlet/tree/develop/src/main/java/io/katharsis/servlet and it should be fairly easy to port it.

chb0github commented 7 years ago

This might make more sense. Lots of requests have been coming in because the current arrangement isn't compatible with spring-security.

chb0github commented 7 years ago

The Counsel of Elders believes that to do this:

1) The order of the filters needs to be changed (and tried!) such that katharsis would come after the Spring dispatcher filter 2) Observe the wreckage and mop up.