kathyisawesome / wc-mnm-mobile-styles

wc-mnm-mobile-styles
GNU General Public License v3.0
2 stars 1 forks source link

When editing a subscription/variation, grey-out "Update Subscription" until valid new state is reached #25

Closed limist closed 2 months ago

limist commented 1 year ago

When editing a subscription (using the wc-mnm-subscription-editing UI), after the first click on the "Update selections" button, the MnM Mobile Styles button of "Update Subscription" is clickable, even though no change of selections (state) has occurred yet. At this point, it might be less confusing if the button was greyed out and unclickable.

image

During editing of quantities etc, if the total quantity of selections doesn't match the MnM container requirement, that button stays greyed-out, which is good!

Once the right quantity is selected, and "Update Subscription" is clicked, something a bit confusing happens: while the save/update is happening, that button stays on and is still clickable, even though the rest of the UI is greyed-out. I think it would be clearer if the "Update Subscription" button text changed to "Saving" and became unclickable.

Not a critical need, but it does make the UI more foolproof (with all the usual caveats about the universe and fools...) and clearer. HTH, thanks!

helgatheviking commented 1 year ago

I've had that thought before... that "update" should not be clickable until something is changed, I just don't know how to detect for that. Technically the config is valid. I think I accounted for it on the backend as nothing happens... but it would be better on the frontend too.

The button being grayed on on update is also a good idea.

limist commented 2 months ago

@helgatheviking This looks to be fixed in latest MnM Mobile Styles version 2.0.1, thanks!