search

katiekuwata / shellinabox

Automatically exported from code.google.com/p/shellinabox
Other
0 stars 0 forks source link

back quote key on the keyboard is not working #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. press back quote (back tick) key on the keyboard will have no effect

What is the expected output? What do you see instead?

expect to be able use back quotes mark

What version of the product are you using? On what operating system?

2.10

Please provide any additional information below.

as above

Original issue reported on code.google.com by jeyfox@googlemail.com on 9 Feb 2010 at 12:02

GoogleCodeExporter commented 9 years ago 
^H works as expected but doesn't map to delete or back space

Original comment by kloevsch...@gmail.com on 22 Oct 2010 at 11:24

GoogleCodeExporter commented 9 years ago 
This may be related, but my back ticks work fine, however the dash and 
underscore do not.  Has anyone seen the same or have a workaround?

Original comment by sandworm...@gmail.com on 1 Nov 2012 at 6:14

GoogleCodeExporter commented 9 years ago 
The above was in Fedora 17/Firefox 16.0.1/ShellInABox 2.14.  Works fine in 
Google Chrome, so I have my workaround.  :)

Original comment by sandworm...@gmail.com on 1 Nov 2012 at 6:36

GoogleCodeExporter commented 9 years ago 
I also have problems with the dash/underscore key. It looks like it might be an 
issue with the newer versions of Firefox.
I was able to reproduce the problem with Firefox 18.0 on Ubuntu 12.04, and 
18.0.1 on Windows XP.
But it worked fine with 13.0.1 on XP and Iceweasel (Firefox) 10.0.12 on Debian 
Wheezy.

Also worked fine with Midori 0.4.7 on Ubuntu 12.04 and IE8 on XP.

Using Shellinabox 2.10 on Debian Wheezy.

Original comment by Geldmach...@gmail.com on 22 Jan 2013 at 3:49

GoogleCodeExporter commented 9 years ago 
I have problems with firefox (version 21) too... Running version 2.14 of 
shellinabox and in the Danish locale (at least) the following keys dont work 
"-" ,"_" , "+", "?" 

Most other special chars (pipes, hats, umlauts, tick and backtick) chars work 
fine..

The above 4 works in Chrome

Original comment by sve...@krap.dk on 3 Jun 2013 at 2:23

GoogleCodeExporter commented 9 years ago 
I've similar issues with Firefox (currently 26) where the '- and _' key and the 
'# and ~' key (this is a United Kingdom English keyboard) don't work.  Again, 
fine on Chrome and even on IE8.

Original comment by gar...@garethwilliams.me.uk on 2 Feb 2014 at 5:51

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
@ (in Chrome) and | (in FF and Chrome) symbols are not working. Danish keyboard 
layout.

Original comment by anne.mar...@gmail.com on 17 Feb 2015 at 12:23

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I fixed + ? - _ < > in Firefox and tested on Windows/Linux/OS X. The new 
keyCodes are added in handleKey/fixEvent/keyDown.

For Macintosh keyboards it's a bit tricky it adds ESC in front of ALT 
combinations (and all keys work without the "1B"/"ESCAPE" char in front that 
gets added). I think there is a place for it in the code to get handled, but 
I'm not sure where to put it right now so it interferes as little as possible. 
I will be looking into a valid solution for Mac when I have dug a little more 
in the source code and understand the addition of modifier keys etc.

Original comment by chr.aas...@gmail.com on 26 Feb 2015 at 2:20

Attachments:

GoogleCodeExporter commented 9 years ago 
The original issue is about the backtick/quote so I will try to address that:

On my keyboard it reports as 187 in Chrome. I comment out case 187 in handleKey:
      //case 187: /* =            */ ch = this.applyModifiers(61, event); break;
(Which translates any ` or ´ to = - since they both trigger keyCode 187 at 
first.)

And now it works for me also in Chrome without outputting = everytime ´ is 
tapped. ("`=")

Original comment by chr.aas...@gmail.com on 27 Feb 2015 at 7:32

GoogleCodeExporter commented 9 years ago 
Hi, 

we have fixes for -, _, #, ~, <, >, + and * characters integrated in our fork 
on Github:
https://github.com/shellinabox/shellinabox

If you wish you can also create a pull request on our repo, as we are trying to 
maintain
shellinabox project with latest fixes.

And a little warning: you are trying to fix to vt100.js file, which is auto 
generated
from vt100.jspp. All you fixes will be over written when you update vt100.jspp 
file. So you
should fix that file.

Bye :)

Original comment by luka.kra...@gmail.com on 8 Mar 2015 at 3:27

GoogleCodeExporter commented 9 years ago 
#12:

That sounds great. Can you use my fix for "?" in that case?

Do you have a comment on the Mac+OPTION situation? To keep it simple the 
problem is as follows: 1B (hex) e.g. ESC is added to every ALT+ combination. Do 
you have a suggestion on where to put a condition? I was thinking maybe 
something an if statement that said "IF ESC+@" or another Mac key combination 
== strip ESC! Because I think the ESC hex char code is intended from the 
original code?

I will be investigating the jspp file now ;)

Original comment by chr.aas...@gmail.com on 8 Mar 2015 at 6:33

GoogleCodeExporter commented 9 years ago 
#13: 

Ok :)

I have taken another look at the issue and I found working patch in issue 202:
https://code.google.com/p/shellinabox/issues/detail?id=202#c23.

You just have to change the code in function keyDown(), for firefox to detect 
new 
keycodes as normal keys.

I have tested this patch on Slovenian, German and Danish keyboard and I think 
it works
fine even for "?" sing :) Can you also test this patch on your keyboard? I 
don't know what
kind of keyboard are you using :)

You can see commit here: 
https://github.com/shellinabox/shellinabox/commit/3570f20b0b0db1909bf19685128ed3
ae3a3445dd

As for the Mac, i don't really know what we should do yet. But I think i saw 
something
on Github that has to do with this ... I will try to find it again and will 
report back.

Original comment by luka.kra...@gmail.com on 8 Mar 2015 at 9:11

GoogleCodeExporter commented 9 years ago 
Hi, I am reporting back :)

I found this fix related to Mac: 
https://github.com/JGRennison/shellinabox/commit/d62c3368094b679071cd62ffbbe4bbe
970fb6f40

Please tell me if you can test this and it works for you. So I can integrate it 
in our fork. For
testing you can just clone this fork: https://github.com/JGRennison/shellinabox

Original comment by luka.kra...@gmail.com on 10 Mar 2015 at 10:10

GoogleCodeExporter commented 9 years ago 
With two above commits everything but ` ´ works.

https://github.com/JGRennison/shellinabox/pull/1

I served you this pull request ^

Original comment by chr.aas...@gmail.com on 10 Mar 2015 at 5:25

GoogleCodeExporter commented 9 years ago 
Hi, glad to hear you got it to work. But I have to tell you that this is 
actually 
not my fork :)

If you wish you can also issue pull request here: 
https://github.com/shellinabox/shellinabox 
This is the one that I take care of and I will happily accept your patch :)

But I think that on "shellinabox/shellinabox" fork we still need to integrate 
changes from
commit d62c3368094b679071cd62ffbbe4bbe970fb6f40 ...

Original comment by luka.kra...@gmail.com on 10 Mar 2015 at 6:02

GoogleCodeExporter commented 9 years ago 
I made a new pull request now.

Original comment by chr.aas...@gmail.com on 10 Mar 2015 at 7:00

GoogleCodeExporter commented 9 years ago 
Ok, we have this fixed and tested on https://github.com/shellinabox/shellinabox 

Thanks and bye :)

Original comment by luka.kra...@gmail.com on 11 Mar 2015 at 3:33