katowulf / mockfirebase

Firebase mock library for writing unit tests (experimental)
157 stars 40 forks source link

Deprecate snapshot.name and ref.name #29

Closed bendrucker closed 9 years ago

katowulf commented 9 years ago

I'm not sure how I feel about removing name(), since it still exists in the core API (deprecated but not removed).

bendrucker commented 9 years ago

Precisely. The changes replicate what the core API does (a console.warn and call through):

https://github.com/katowulf/mockfirebase/blob/bfb7beca189b2e15824ed2f10b87edcfafa905e6/src/utils.js#L11-L14

katowulf commented 9 years ago

wtfh, obviously you just added that because I can totally read :eyes:

katowulf commented 9 years ago

Also, am I fired yet? I hope so because I could use a vacation :tropical_drink: :tropical_fish: :palm_tree:

bendrucker commented 9 years ago

:) Vacation away!