search

katubug / CottageWitch119

13 stars 0 forks source link

[Bug] Wolf's Collar Tags duplicates enchantments onto unenchanted Collar Tags #56

Closed tali9 closed 9 months ago

tali9 commented 11 months ago

THIS APPLIES TO COTTAGE WITCH: RECAST- SORRY!

Describe the bug A Wolf's Collar Tags duplicates enchantments onto unenchanted Collar Tags by replacing the enchanted collar tag

To Reproduce Steps to reproduce the behavior:

  1. Get a wolf
  2. Give it an enchanted collar tag [Can be any enchantment]
  3. Replace the enchanted collar tag with an unenchanted collar tag
  4. Enchanted collar returns, then reapply it to re-replace the unenchanted collar tag.
  5. Previously unenchanted collar tag returns as enchanted

Expected behavior Applying an unenchanted collar tag instead of an enchanted collar tag, then reapplying the enchanted collar tag should return an unenchanted collar tag.

Screenshots

https://github.com/katubug/CottageWitch119/assets/20379159/03058939-9531-4cc5-9ce3-902cefc47022

What Cottage Witch version are you using? Version: 1.4.0

Additional context While not too critical since you can enchant 64 collar tags without additional cost, it becomes a problem if someone severely abuses this and makes more than 64 enchanted collar tags for the price of one.

katubug commented 11 months ago

Hi, thank you for reporting this! If you can report this to the Domestication Innovation mod author, they should be able to fix it! I don't think there's anything I can personally do though.

On Thu, Oct 12, 2023, 11:37 AM tali9 @.***> wrote:

Describe the bug A Wolf's Collar Tags duplicates enchantments onto unenchanted Collar Tags by replacing the enchanted collar tag

To Reproduce Steps to reproduce the behavior:

  1. Get a wolf
  2. Give it an enchanted collar tag [Can be any enchantment]
  3. Replace the enchanted collar tag with an unenchanted collar tag
  4. Enchanted collar returns, then reapply it to re-replace the unenchanted collar tag.
  5. Previously unenchanted collar tag returns as enchanted

Expected behavior Applying an unenchanted collar tag instead of an enchanted collar tag, then reapplying the enchanted collar tag should return an unenchanted collar tag.

Screenshots

https://github.com/katubug/CottageWitch119/assets/20379159/03058939-9531-4cc5-9ce3-902cefc47022

What Cottage Witch version are you using? Version: 1.4.0

Additional context While not too critical since you can enchant 64 collar tags without additional cost, it becomes a problem if someone severely abuses this and makes more than 64 enchanted collar tags for the price of one.

— Reply to this email directly, view it on GitHub https://github.com/katubug/CottageWitch119/issues/56, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5QGRWZNHL3ADDTTRGTX7AMGNANCNFSM6AAAAAA554QMVM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tali9 commented 11 months ago

Ah- I reposted it in Cottage Witch: Recast's Repository before this- Sorry!