katyo / oboe-rs

Rust bindings for Oboe high-performance audio IO Android library
64 stars 22 forks source link

Update to jni 0.17 #24

Closed bjorn3 closed 3 years ago

bjorn3 commented 3 years ago

This updates oboe to use jni version 0.17. This prevents jni being compiled twice when depending on the cpal crate, which depends on jni 0.17 and oboe 0.3.

I wasn't able to update it to the latest version 0.18 of jni due to the following error:

error[E0277]: `?` couldn't convert the error to `jni::errors::Error`
  --> oboe/src/java_interface/devices_info.rs:68:59
   |
68 |                 .ok_or_else(|| "Invalid device direction")?,
   |                                                           ^ the trait `From<&str>` is not implemented for `jni::errors::Error`
   |
   = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
   = help: the following implementations were found:
             <jni::errors::Error as From<TryLockError<T>>>
   = note: required by `std::convert::From::from`
bjorn3 commented 3 years ago

CI failure seems unrelated.