search

katyo / oboe-rs

Rust bindings for Oboe high-performance audio IO Android library
64 stars 22 forks source link

Update jni #33

Closed DJMcNab closed 3 years ago

DJMcNab commented 3 years ago

Bevy's cargo deny check failed because cpal depends on jni directly and via this crate.

This meant that there were multiple jni versions in our tree.

Please note that I haven't tested this, and haven't managed to build locally, so I'm going to see what CI says first - hopefully it will go through without issue.

DJMcNab commented 3 years ago

@katyo would it be possible to get a release containing this please?

It's still causing the issue for bevy (to clarify, it's not blocking anything, it's just muddying CI status).

If you don't think this is a semver compatible change, then I don't want to push for a major release just for this dependency - I'm unclear how much jni influences the public interface.

Of potential note here is that cpal upgraded their jni version in a patch release, and don't seem to have had any problems there

katyo commented 3 years ago

@DJMcNab version 0.4.3 issued on crates.io!

katyo commented 3 years ago

@DJMcNab Unfortunately I forget to update pre-generated bindings... I will issue 0.4.4 for now.